Adding JetBrains vSphere plugin support #162
Conversation
thor
changed the title
thor
changed the title
|
I've updated it to include tests. Can we get this merged, @mayn? |
thor
force-pushed
the
master
branch
2 times, most recently
from
6755338
to
847ef44
Compare
| @@ -0,0 +1,146 @@ | |||
| """ | |||
| Copyright 2018 Thor K. Hoegaas <thor at roht no> | |||
There was a problem hiding this comment.
i think adding this will potentially complicate things for me later.
There was a problem hiding this comment.
I would hope not; the copyright notice does not change anything for your current license unless you want to change your license to an incompatible one at a later point?
|
@thor looking to hear back from you, left some comments on your PR. |
|
@mayn my apologies for the late reply; hats have been burning! I've addressed your first question, and await your response regarding the second. |
|
not a problem. I merged another PR, it caused a conflict w/ your PR.(believe it was because the other PR also introduced the communtity/builders.py ). I would have taken care of it, but it will involve removing your copyright. Please resolve the conflict if still interested. Thanks. |
|
I'll take a look at it by the end of the week.
Thanks for the update.
…On Mon, Feb 4, 2019 at 2:09 AM Matthew Aynalem ***@***.***> wrote:
not a problem. I merged another PR, it caused a conflict w/ your
PR.(believe it was because the other PR also introduced the
communtity/builders.py ). I would have taken care of it, but it will
involve removing your copyright.
Please resolve the conflict if still interested.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#162 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOT-ULST9H31r841U0gmrshY1lrRq2jks5vJ4hKgaJpZM4Z5aRF>
.
|
Uses a base class for the both of them, adding support for vsphere-iso and vsphere-clone.
Used tests from VMware builder, that very simply verifies that things work. Note that we do not use template, as it fails together with troposphere included with packerlicious. Re: troposphere, renamed keyword argument to allow for the usage of the value "template" in a specification.
|
Conflict resolved, @mayn. My apologies for the extended delay. |
|
Is this going to be merged anytime soon? |
|
If we can get a 👍 from @mayn, I'll get this rebased, but nonetheless, if you check it out it should be usable, @claudekenni. :) |
|
@thor this isn’t going to get merged with the addition of your copyright header. @claudekenni based on the outcome of the above the PR will get merged or I’ll provide you an alternate implementation. |
|
@mayn if you must, feel free to remove the notice if you may elaborate on how it's problematic for you and the APLv2. Otherwise it seems odd and arbitrary, but beyond that, being mostly a list of properties and hardly much "code" in itself, so if there's any particular reason for it, and you may elaborate on it, then sure -- I just want to leave my tiny mark -- and get that |
Adds support for the types
vsphere-isoandvsphere-clonefrom the open source JetBrains vSphere plugin.Issue
There was no support for the vSphere plugin.
List of Changes Proposed
Adds support for the
vsphere-isoandvsphere-clonetypes to facilitate packerlicious support for these too.Testing Evidence
I've used it myself to build both ISO and clone templates, but I'll let the CI speak for itself.
One note may be that it is not Python 2 compatible, but I can fix that if you'd like. 👍