Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memory, usb, and cpus options to virtualbox iso builder #163

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Add memory, usb, and cpus options to virtualbox iso builder #163

merged 2 commits into from
Jan 22, 2019

Conversation

iepathos
Copy link
Contributor

add memory, usb, and cpus options to virtualbox iso

Issue

List of Changes Proposed

Testing Evidence

@iepathos
Update builder.py
de57c2f 
add memory, usb, and cpus options to virtualbox iso
@iepathos
fixed bug building without options
732a943 
Use False values for new options for not required instead of the default values for the options.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 732a943 on iepathos:patch-1 into 79d4ed4 on mayn:master.

@mayn mayn added this to the 1.2.0 milestone Jan 22, 2019
@mayn mayn merged commit 44a4301 into mayn:master Jan 22, 2019
@mayn
Copy link
Owner

mayn commented Jan 22, 2019

thanks @iepathos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builder enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iepathos @coveralls @mayn