-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python 2.6 on Appveyor CI #53
Conversation
Fixes #52 Somewhere in the dependency tree, cryptography is being installed. In the recent 2.1 release of the cryptography package, Python 2.6 was deprecated.
@shakeelmohamed thanks for your PR! |
@mayn Now Python 3.3 fails to build the cryptography package! 😄 Is there a way to conditionally set this restriction for Python 2.6 only? |
@shakeelmohamed didn't see that one coming. 😄 Might require minor refactor to the tox profile for appveyor also (not 100% sure) see: |
This solution works, but it's a bit clunky since it bring in another requirements file. Changing the tox config didn't seem to work, I'm guessing that's because One possible solution would be moving the CI installations to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey this is great.
Given that this is only for the build environments and tox -e py26 --recreate
still works locally for users, I can live with the clunk.
Add version ceiling on cryptography transitive dependency
Fixes #52
Somewhere in the dependency tree, cryptography is being installed.
In the recent 2.1 release of the cryptography package, Python 2.6
was deprecated.