Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ react native support #7

Merged
merged 8 commits into from
Jun 23, 2020
Merged

✨ react native support #7

merged 8 commits into from
Jun 23, 2020

Conversation

mayteio
Copy link
Owner

@mayteio mayteio commented Mar 3, 2020

  • have migrated from react-scripts to jest, need to get jest.rn.config.js working.

@mayteio mayteio mentioned this pull request Mar 3, 2020
@hsavit1
Copy link

hsavit1 commented Jun 5, 2020

how is this going? is there anything that you're stuck on in particular that you need help with? What do you need besides upgraded tests?

@mayteio
Copy link
Owner Author

mayteio commented Jun 6, 2020

Hey @hsavit1, I haven’t made any progress on this. I can look at it this week, or accepting pull requests 🙏

@mayteio
Copy link
Owner Author

mayteio commented Jun 16, 2020

Hey @hsavit1 do you have capacity to work on this? I am snowed under with work at the moment.

I think a mild restructure is required. We'd need to move things into a src/web, src/react-native structure then update rollup to generate multiple bundles - web @ root and rn at @harelpls/use-pusher/react-native. I personally haven't done this before, though am keen to learn. Do you know any resources for this?

@hsavit1
Copy link

hsavit1 commented Jun 16, 2020

can't say I've ever done anything like that before. I've never built a published custom hook before. I'll definitely stick my neck out there though and let you know what I find!

@mayteio mayteio merged commit d03d5f0 into master Jun 23, 2020
@mayteio
Copy link
Owner Author

mayteio commented Jun 23, 2020

resolves #5

@mayteio mayteio deleted the feature/react-native branch August 19, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants