Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trezor Support #27

Closed
vertoe opened this issue Mar 3, 2015 · 11 comments
Closed

Trezor Support #27

vertoe opened this issue Mar 3, 2015 · 11 comments

Comments

@vertoe
Copy link
Contributor

vertoe commented Mar 3, 2015

What's the status of Trezor hardware support? Electrum 2.0 works with Trezor, what are the plans for encompass?

I'm asking because we are currently putting alot of work into electrum porting and maintainance, but it looks like encompass is the better product in the end, and we might join our effords and work on this together.

@guruvan
Copy link
Member

guruvan commented Mar 3, 2015

@vertoe - thank you! I think we'll see the two shine in different areas. Currently the plugins are disabled in Encompass, but this is a high priority. We'll add a milestone now of Encompass 1.0 for the electrum 2.0 integration, with my best estimate for a delivery in mid-late April.

@ELM4Ever
Copy link

ELM4Ever commented Mar 4, 2015

The problem with Trezor support in Encompass is that Trezor only currently supports BTC, LTC, DRK, DOGE, and NMC. Encompass supports BTC, LTC, DRK, MZC, VIA. The Encompass team would have to disable Trezor support for MZC and VIA and allow it for the others.

Another option would be for Encompass to request Trezor to add VIA and MZC to their supported coins - it is a simple pull request to do to https://github.com/trezor/trezor-mcu/blob/master/firmware/coins.c

... and assign a BIP44 coin type to MZC and VIA....

@guruvan
Copy link
Member

guruvan commented Mar 4, 2015

@ELM4Ever all currencies in Encompass are BIP44 registered coins.

The MZC Trezor support will happen, though I don't yet have a timeframe - that was the plan to put a PR in there. Also, I'm sure that we'll support the plugins on a chain-by-chain basis for most, as many of the existing plugins for Electrum are BTC specific.

@ELM4Ever
Copy link

ELM4Ever commented Mar 4, 2015

Agree, but not all coins are supported by Trezor. They have to have their specifics incorporated in their "coins.c" file (see above comment).

@vertoe
Copy link
Contributor Author

vertoe commented Mar 4, 2015

Adding them to coins.c is not enough afaik.
https://darkcointalk.org/threads/trezor-for-darkcoin.4162/page-2#post-44343

@guruvan
Copy link
Member

guruvan commented Mar 4, 2015

Again - Trezor support can and will be added, as time permits. It's a high priority, but we do have plans ahead of this. AFAICT it should not be necessary to support all Encompass coins with Trezor to enable the plugin for certain coins.

@guruvan guruvan closed this as completed Mar 4, 2015
@guruvan guruvan reopened this Mar 4, 2015
@guruvan
Copy link
Member

guruvan commented Mar 4, 2015

wrong button! Re openend as this is still on the roadmap!

PS. I've personally been eyeing that trezor code for some time....for more than a few reasons ;)

@guruvan
Copy link
Member

guruvan commented Mar 4, 2015

Also - we'll need to determine how easily we can support the blockexplorer requirements

@Kefkius might know off the top whether the mazawatch code on mazachain will support this out of the box, or if we'd need to enhance/update or just put up another.

@vertoe
Copy link
Contributor Author

vertoe commented Mar 4, 2015

insight for mazacoin? we are also working on bip44 integration for insight, maybe this is yet another project we should work together on. we should share contact details already ;-)

@guruvan
Copy link
Member

guruvan commented Mar 4, 2015

Ping me on IRC ( guruvan ) and we'll do so - I'll be there all day - and yes BIP44 for insight is definitely something we can work on together - email is guruvan at maza.club

@Kefkius
Copy link
Member

Kefkius commented Apr 1, 2015

Fixed in #50 ;)

@Kefkius Kefkius closed this as completed Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants