Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Displayed total registered users in homepage #123

Merged
merged 6 commits into from Oct 23, 2023
Merged

FEAT: Displayed total registered users in homepage #123

merged 6 commits into from Oct 23, 2023

Conversation

kliu57
Copy link
Contributor

@kliu57 kliu57 commented Oct 23, 2023 •
edited

  • displayed registered users count in homepage
  • used API from FEAT: Count notion database rows #121 to get the count
  • count is also cached in localStorage (upon second refresh, as long as localStorage has a value, it will not call the API again)

Past conversations can be seen in previous unmerged PR

Closes #88

Files updated

  • src/app/page.tsx (the homepage - added code to get user count and display and cache it)
  • src/lib/api.ts (added a new function getUserCount, this function accesses the /api/statistics route from FEAT: Count notion database rows #121)

Testing

test2
test

Testing cache:

cache1
cache2

@vercel
Copy link

vercel bot commented Oct 23, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @mazipan on Vercel.

@mazipan first needs to authorize it.

@kliu57 kliu57 marked this pull request as ready for review October 23, 2023 08:08
mazipan
mazipan previously approved these changes Oct 23, 2023
View reviewed changes
@mazipan mazipan changed the title Displayed total registered users in homepage and cached in localstorage FEAT: Displayed total registered users in homepage and cached in localstorage Oct 23, 2023
@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tanyaaja ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 9:09am

@mazipan mazipan changed the title FEAT: Displayed total registered users in homepage and cached in localstorage FEAT: Displayed total registered users in homepage Oct 23, 2023
@mazipan mazipan added hacktoberfest-accepted automerge Kodak's Auto Merge Label labels Oct 23, 2023
@kodiakhq kodiakhq bot merged commit 6927644 into mazipan:master Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazipan mazipan mazipan left review comments

Assignees
No one assigned
Labels
automerge Kodak's Auto Merge Label hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing total count of user registered in homepage
2 participants
@kliu57 @mazipan