Accept limited photo library authorization #22
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>PHPhotoLibraryPreventAutomaticLimitedAccessAlert</key> | ||
| <true/> | ||
| </dict> | ||
| </plist> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // | ||
| // LimitedLibraryPicker.swift | ||
| // Queryable | ||
| // | ||
| // Created by Jaden Geller on 10/30/23. | ||
| // | ||
|
|
||
| import SwiftUI | ||
| import PhotosUI | ||
|
|
||
| struct LimitedLibraryPicker: UIViewControllerRepresentable { | ||
| @Binding var isPresented: Bool | ||
|
|
||
| func makeUIViewController(context: Context) -> UIViewController { | ||
| .init() | ||
| } | ||
|
|
||
| class Coordinator { | ||
| var isPresented = false | ||
|
There was a problem hiding this comment. Coordinator tracks whether or not the picker is actually presented. Binding tracks whether or not the view wants it to be presented. This allows us to: (a) prevent attempting to present the picker again when it is already presented, and (b) update the binding value back to Technically, neither of these code paths are exercised by the app, but it seemed worth implementing this properly in case the calling code changes. |
||
| } | ||
| func makeCoordinator() -> Coordinator { | ||
| .init() | ||
| } | ||
|
|
||
| func updateUIViewController(_ controller: UIViewController, context: Context) { | ||
| if isPresented, !context.coordinator.isPresented { | ||
| Task { | ||
| context.coordinator.isPresented = true | ||
| await PHPhotoLibrary.shared().presentLimitedLibraryPicker(from: controller) | ||
| context.coordinator.isPresented = false | ||
| await MainActor.run { isPresented = false } | ||
| } | ||
| } | ||
| else if !isPresented, context.coordinator.isPresented { | ||
| Task { | ||
| await MainActor.run { isPresented = true } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension View { | ||
| func limitedLibraryPicker(isPresented: Binding<Bool>) -> some View { | ||
| overlay(LimitedLibraryPicker(isPresented: isPresented)) | ||
|
There was a problem hiding this comment. It doesn't actually matter if this is an overlay, background, etc. It just matters that the UIViewControllerRepresentable is part of the view hierarchy so it can get a reference to a UIViewController to present the limited library picker. |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops almost forgot to swap this out
I think I don't like using the default argument in this way, but waiting for feedback re: logs & style before changing anything