Skip to content
This repository has been archived by the owner on Nov 2, 2020. It is now read-only.

fix array elements chevron bad positioning + fix bad sizing of array elements #41

Merged
merged 1 commit into from
Jun 3, 2016

Conversation

Sparksx
Copy link
Contributor

@Sparksx Sparksx commented Jun 3, 2016

Hi

In my previous pull request I've fixed height of array element to 30px
But after some testing, it's causing visual bug on array of array or array of object.

Height must not be fixed to 30px but minimum height of element is 30px.
With min-height 30px array of boolean is nice and array of array or array of object is correctly sized.

My bad, I'm sorry for that.

I've already fixed position of chevron (in collision with list style type)

see the difference between your's and mine

capture d ecran 2016-06-03 a 11 43 26
capture d ecran 2016-06-03 a 11 43 36

tested with
{ "test": [ { "field": "value", "test": [ { "boolean": [ false, true ] } ] } ] }

Sorry again

@mb21 mb21 merged commit e28e3c7 into mb21:gh-pages Jun 3, 2016
@mb21
Copy link
Owner

mb21 commented Jun 3, 2016

thanks, yeah it's a bit tricky... there's also #8 that I never got around to resolve fully...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants