Fixes #3988 - use require instead of autoload_once_paths #1
Conversation
| # Require the following paths only once in development environment | ||
| # this is useful to keep singletons from reloading. | ||
| if Rails.env.development? | ||
| Dir.glob(["#{Rails.root}/app/services/foreman/**/*.rb", |
There was a problem hiding this comment.
It might be better to load only the file(s) we need for the menu, if that's possible..
There was a problem hiding this comment.
I wanted to keep the previous behaviour as much as possible, to keep the risk of actually braking something, as low as possible :)
There was a problem hiding this comment.
I was a bit reluctant with this change in the first place, so the more we can have in the autoload path, and the least in the "never reload" path, the better it'll be for us devs.
There was a problem hiding this comment.
Just discussed with @mbacovsky, I think the only two files we need to keep outside the autoloader are app/services/foreman/plugin.rb for plugin registrations and app/services/menu/manager.rb for added menu items.
There was a problem hiding this comment.
After some testing, more files turned out to be required (all the menu stuff) to keep the singletons working with plugins. I've pushed updated version, keeping the minimum needed to be required.
The `autoload_once_paths` were used incorrectly. From http://guides.rubyonrails.org/configuring.html: > config.autoload_once_paths accepts an array of paths from which > Rails will autoload constants that won't be wiped per request. > Relevant if config.cache_classes is false, which is the case > in development mode by default. Otherwise, all autoloading happens > only once. > All elements of this array must also be in autoload_paths. In our case, the paths are not in autoload_paths directly.
|
👍 thanks @iNecas! |
Fixes theforeman#3988 - use require instead of autoload_once_paths
|
:D |
The
autoload_once_pathswere used incorrectly. From http://guides.rubyonrails.org/configuring.html:In our case, the paths are not in autoload_paths directly.