Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adminuser #14

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adminuser #14

wants to merge 5 commits into from

Conversation

aduprat
Copy link
Collaborator

@aduprat aduprat commented Dec 12, 2014

No description provided.

@buildhive
Copy link

mbaechler » Greenmail #17 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

mbaechler » Greenmail #18 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

mbaechler » Greenmail #19 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive
Copy link

mbaechler » Greenmail #20 SUCCESS
This pull request looks good
(what's this?)

@@ -27,7 +31,7 @@ protected void doProcess(ImapRequestLineReader request,
ImapSession session)
throws ProtocolException, FolderException, AuthorizationException {
String mailboxName = parser.mailbox(request);
parser.endLine(request);
// parser.endLine(request);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you not restore this line ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, i can't, because of the extra Cyrus parameter (partition).
The goal of this commit is to make the IMAP CREATE command compatible with Cyrus.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks, it just looks weird to have this line commented.
Don't you prefer to either remove it at all or tell in a comment why you did that ?

@Lewik
Copy link

Lewik commented Feb 8, 2017

Will maintainers merge this pr? (Out team very needs admin user)
Plus we need commands to configure admin users from command line.
I can repeat admin part code into new pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants