Skip to content

Commit

Permalink
gnu: graphicsmagick: Fix CVE-2016-5118.
Browse files Browse the repository at this point in the history
* gnu/packages/patches/graphicsmagick-CVE-2016-5118.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/imagemagick.scm (graphicsmagick): Use it.
  • Loading branch information
lfam committed May 30, 2016
1 parent b3d20b8 commit d886277
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 0 deletions.
1 change: 1 addition & 0 deletions gnu/local.mk
Expand Up @@ -518,6 +518,7 @@ dist_patch_DATA = \
%D%/packages/patches/gobject-introspection-absolute-shlib-path.patch \
%D%/packages/patches/gobject-introspection-cc.patch \
%D%/packages/patches/gobject-introspection-girepository.patch \
%D%/packages/patches/graphicsmagick-CVE-2016-5118.patch \
%D%/packages/patches/grep-timing-sensitive-test.patch \
%D%/packages/patches/grub-CVE-2015-8370.patch \
%D%/packages/patches/grub-gets-undeclared.patch \
Expand Down
1 change: 1 addition & 0 deletions gnu/packages/imagemagick.scm
Expand Up @@ -160,6 +160,7 @@ script.")
(uri (string-append "ftp://ftp.graphicsmagick.org/pub/"
"GraphicsMagick/" (version-major+minor version)
"/GraphicsMagick-" version ".tar.xz"))
(patches (search-patches "graphicsmagick-CVE-2016-5118.patch"))
(sha256
(base32
"03g6l2h8cmf231y1vma0z7x85070jm1ysgs9ppqcd3jj56jka9gx"))))
Expand Down
19 changes: 19 additions & 0 deletions gnu/packages/patches/graphicsmagick-CVE-2016-5118.patch
@@ -0,0 +1,19 @@
Fix CVE-2016-5118 (popen() shell vulnerability via filename).

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-5118

Upstream patch copied from the bug announcement:
http://seclists.org/oss-sec/2016/q2/432
https://marc.info/?l=oss-security&m=146455222600609&w=2

diff -r 33200fc645f6 magick/blob.c
--- a/magick/blob.c Sat Nov 07 14:49:16 2015 -0600
+++ b/magick/blob.c Sun May 29 14:12:57 2016 -0500
@@ -68,6 +68,7 @@
*/
#define DefaultBlobQuantum 65541

+#undef HAVE_POPEN

/*
Enum declarations.

0 comments on commit d886277

Please sign in to comment.