Automatic refinement of elements #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all user-added elements are added to this list - Model.elementlist is reserved for computation elements
- move compute_z1z2 to util.py - add refine_n_segments
- move compute_z1z2 to util.py - add refine_n_segments
+ some minor style fixes
- add refine_level kwarg - add _refine method (using refine_n_segments for now) that returns new refined inhom - modify create_elements to return elements (instead of automatically adding to the model elementlist) - store user input in self._input for creating refined elements - add addtomodel kwarg to all inhoms
- create new elements - distrbute Q according to new segment lengths
- add refine_level kwarg - add option to skip adding element to aquifer elementlist (needed for LineSinkString elements)
- add _refine method for creating new elements with correct head-specification
…ublet - add _refine method - add refine_level kwarg - add addtoaq kwarg to initialize (for String elements) - store user inputs
- add refine_level kwarg - introduce internal _x, _y and _xy vars - add _refine method - move building linedoublets into initialize
- add aq.inhoms for user-added inhoms - add aq.inhomlist for computation inhoms
- use original element but update internal parameters - add inhom.extent as useful attribute
- solution for cases with subsequent solves, first with refine, next without - implement _reset() methods to reset internal vars to original values - modify initialize calls to call _reset() - add tests
rename LineSinkStringBase2 to LineSinkStringBase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #103 this PR implements automatic refinement of elements in TimML.
See the example notebook for a detailed description of the new functionality.
One thing I'm not entirely sure about is the refinement of single line-sinks. This cannot be done without creating new elements, which means the reference to the element original added by the user cannot be used for computations, which might be a bit confusing. I've implemented refinement for these elements now, but we could also choose not to support refinement for single line-sink elements, and point users to their LineSinkString counterparts.
Anyway, curious to get your feedback!