Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get rid of npm install hook and use findChrome on demand #34

Closed
mbalabash opened this issue Nov 17, 2021 · 3 comments
Closed

Try to get rid of npm install hook and use findChrome on demand #34

mbalabash opened this issue Nov 17, 2021 · 3 comments

Comments

@mbalabash
Copy link
Owner

After latest security incidents in October and November there is discussion started about making npm install scripts opt-in.

Right now we use this hook to locate chrome locally or download it if it hasn't found. If it was found, we save its executablePath in chrome.json.

But, we probably can move this operation from install stage to first launch stage with same logic.
Although my npm account covered with 2fa, I think it won't be a mistake to investigate this opportunity.

@mbalabash
Copy link
Owner Author

Hey @ai
What do you think about it in context of size-limit/time use-case and users?

@ai
Copy link
Contributor

ai commented Nov 17, 2021

I am OK for both options

@mbalabash
Copy link
Owner Author

@ai Released in estimo@2.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants