Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Having spent now a few months with bumpver for a project, I became frustated by the GITHASH part:
Because GITHASH forces a starting
.
then a hash, it is not possible to have a version that matchesboth
v2023.40.0
andv2023.40.0+1234
. The former can be obtained withvYYYY.0W.INC0
, the latter withvYYYY.0W.GITHASH
. If one combines both withvYYYY.0W[.INC0][GITHASH]
, then trying to set a version tov2023.40.0
will just omit the last.0
, because it's the default value of optional.INC0
. The resulting versionv2023.40
is not semver compliant, and will break some tools (for example
cargo
)I have added the
HASH
part, to be any hexadecimal hash.This is useful to add a hash-like that may come from any checksum, vsc.
This allows patterns where a hash may be present or ommitted, such as vYYYY.0W.INC0[\+HASH] which can accept v2023.40.0 or v2023.40.1+abc123