Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@opReplaceFace: DIRECT_EDIT_REPLACE_FACE_FAILED #3

Open
emagdalenaC2i opened this issue Nov 30, 2018 · 15 comments
Open

@opReplaceFace: DIRECT_EDIT_REPLACE_FACE_FAILED #3

emagdalenaC2i opened this issue Nov 30, 2018 · 15 comments
Labels
bug Something isn't working

Comments

@emagdalenaC2i
Copy link
Collaborator

See FeatureScript notices in Part Studio 1

    @opReplaceFace: DIRECT_EDIT_REPLACE_FACE_FAILED
    557:12
    923:13
    227:32
    131:13
    54:17
     
     
@emagdalenaC2i emagdalenaC2i mentioned this issue Nov 30, 2018
14 tasks
@mbartlett21
Copy link
Owner

This is due to concave welds not extending.

@mbartlett21 mbartlett21 added the bug Something isn't working label Dec 1, 2018
@emagdalenaC2i
Copy link
Collaborator Author

@mbartlett21 is this fixed?

@mbartlett21
Copy link
Owner

No. 😢

@emagdalenaC2i
Copy link
Collaborator Author

I think I didn't see it again. Is it because we add a silent try?

@mbartlett21
Copy link
Owner

Is the weld that you are testing it with a convex or flat one?

@emagdalenaC2i
Copy link
Collaborator Author

I think so

@mbartlett21
Copy link
Owner

This only happens with concave welds

@emagdalenaC2i
Copy link
Collaborator Author

No. I have just tested with CONVEX

@emagdalenaC2i
Copy link
Collaborator Author

@emagdalenaC2i
Copy link
Collaborator Author

You have to remove silent in the try

@mbartlett21
Copy link
Owner

The only silent in the github one is for weld numbers
Should i merge to Onshape from gihthub, or have you already?

@emagdalenaC2i
Copy link
Collaborator Author

It was in a closed PR, I have just reopened #39

@mbartlett21
Copy link
Owner

I just changed the code in Onshape to reflect the code in github.
You can see it failing in the part studio you are on.

@emagdalenaC2i
Copy link
Collaborator Author

FeatureScript notice show this twice with CONCAVE (lines 787 and 781) and just one with CONVEX (line 787)

@emagdalenaC2i
Copy link
Collaborator Author

Do you want the faces of the fillets (highlighted in the image below) to also join as miter?
captura

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants