Skip to content

Commit

Permalink
Remove unused flags "velox_memory_pool_mb" (facebookincubator#10111)
Browse files Browse the repository at this point in the history
Summary:
The `velox_memory_pool_mb` gflag is not used anywhere.

Pull Request resolved: facebookincubator#10111

Reviewed By: amitkdutta

Differential Revision: D58364444

Pulled By: xiaoxmeng

fbshipit-source-id: d8f9f2d086d06887115c12753bb7fc8e914aa26b
  • Loading branch information
lingbin authored and facebook-github-bot committed Jun 10, 2024
1 parent b63fc8c commit de55473
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion velox/common/memory/MemoryAllocator.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#include "velox/common/memory/Allocation.h"
#include "velox/common/time/Timer.h"

DECLARE_int32(velox_memory_pool_mb);
DECLARE_bool(velox_time_allocations);

namespace facebook::velox::memory {
Expand Down
1 change: 0 additions & 1 deletion velox/common/memory/tests/MemoryAllocatorTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#include <fstream>
#endif // linux

DECLARE_int32(velox_memory_pool_mb);
DECLARE_bool(velox_memory_leak_check_enabled);

using namespace facebook::velox::common::testutil;
Expand Down
5 changes: 0 additions & 5 deletions velox/flag_definitions/flags.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@

// Used in velox/common/memory/MappedMemory.cpp

DEFINE_int32(
velox_memory_pool_mb,
4 * 1024,
"Size of file cache/operator working memory in MB");

DEFINE_int32(
velox_memory_num_shared_leaf_pools,
32,
Expand Down

0 comments on commit de55473

Please sign in to comment.