Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid git submodule. #23

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Conversation

ArthurSonzogni
Copy link
Contributor

Hi Matteo,
Could you please take a look?

I am just removing an issue on my way, but I totally ignore what I am touching here ;-)

Please note that git doesn't support storing empty directory, so the build/ directory will probably not be created on git clone. If it is required to exist, you probably need to add a placeholder file in this directory.

@mbasso
Copy link
Owner

mbasso commented Jun 1, 2019

Hi @ArthurSonzogni,
thank you for opening an issue and following with this PR!
I checked the problem and it seems that there are some folders/files into the website folder that should not have been pushed. Therefore, the build folder, automatically generated by docusaurus, is one of the those. I think we should delete them and fix the website/.gitignore file.
At the moment has something like this:

website/translated_docs
website/build/
website/yarn.lock
website/node_modules

website/i18n/*
!website/i18n/en.json

We should remove the website prefix for each line except the third one that should be deleted entirely, since we want to push yarn.lock .
Can you please update the PR, so I can merge?

Remove website/build/asm-dom-gh-pages
Update the .gitignore to prevent future mistakes.

See mbasso#22
@ArthurSonzogni
Copy link
Contributor Author

Thanks! I addressed your comments.

@mbasso
Copy link
Owner

mbasso commented Jun 1, 2019

Perfect! Thank you!

@mbasso mbasso merged commit 49131a4 into mbasso:master Jun 1, 2019
@mbasso mbasso mentioned this pull request Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants