This repository has been archived by the owner on Jun 5, 2021. It is now read-only.
Matrix signals #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Too much boilerplate shared between Vector and MatrixSignals!
Simplify construction of Signals - Make conversion to time arrays in seconds an orthogonal process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds MatrixSignal and RegularMatrixSignal types, and fixes #2. It makes working with matrices a little nicer (no need to generate lots of Views), but I don't like the two-fold increase in complexity (now there are four types!).
At first I wasn't sure I was going to merge this, but the more I think about it, the more I think it's a nice gain.