MBBSEmu SoftPatch Support #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `module.json` to load as JSON, not as an AppConfig - Add Classes for Patching Objects - Applying Absolute Offset Patching on Module Load
- Cast `ModuleEnabled` as nullable Bool - Handle Nullable Bool when referencing `ModuleEnabled` - Add new JsonBooleanConverter to handle various cases - If `ModuleEnabled` is null (omitted from Module JSON), default to enabled `true`
- Had to handle Absolute File Patching prior to NE File Loader (which breads the raw data out into segments) - Pass NE File Data into NE Loader vs. having it load in the constructor
paladine
reviewed
Oct 4, 2021
|
|
||
| public override void Write(Utf8JsonWriter writer, bool value, JsonSerializerOptions options) | ||
| { | ||
| switch (value) |
There was a problem hiding this comment.
9 lines down to 1?
return writer.WriteStringValue(value ? "1" : "0");
paladine
approved these changes
Oct 4, 2021
paladine
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to MBBSEmu to "SoftPatch" modules, where modifications to modules can be loaded via config without having to apply changes directly to DLL files.
Patchoption to the Module Configuration JSON SpecificationHex(string of Hex Codes to be patched in) andText(string to be patched in directly)System.Text.Json(versus loading it as a configuration file viaSystem.Configuration)modules.jsonthat is included to reflect how to apply a SoftPatchCurrently only
AbsoluteOffsetis supported, I'll add support forSEGMENT:OFFSETpatches in another PR, but the properties are defined here.This will allow for easy byte level patching of binaries without having to use a hex editor.