Modules Config "BasePath" #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `BasePath` Option to Module Configuration JSON - Create new JSON ModuleConfiguration Converter that loads Modules from the JSON and applies Base Path to each deserialized Module - ModeConfiguration will now apply `BasePath` to a modules specified path if it is set, and the Module path specified isnt a Root path
|
Oh -- I guess I could write some Unit Tests for this as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal with this PR is that we can specify one
BasePathin a Module Configuration File. In the near future, this will make packaging a "MBBSEmu Game Pack" easier to distribute as every module can be relatively pathed off a root folder with a single configuration.Additionally, it should make managing a Modules Config JSON file with multiple modules easier to manage if all the modules share the same relative path.
BasePathOption to Module Configuration JSONBasePathto a modules specified path if it is set, and the Module path specified isnt a Root path