Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type of ILiteRepository.Insert to match ILiteDatabase.Insert #2260

Merged
merged 1 commit into from Mar 9, 2023

Conversation

InvisiblePhil
Copy link

The documentation of ILiteRepository.Insert implied it returns the ID of the insert, but it returned void

Changed to make this API consistent

Copy link

@mahop-net mahop-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary should be changed accordingly.

If not accepted summary should also be changed... :-)

@InvisiblePhil
Copy link
Author

Summary should be changed accordingly.

If not accepted summary should also be changed... :-)

The summary as-is notes the method returns the ID - so what change is needed if the PR is accepted?

@mahop-net
Copy link

mahop-net commented Jan 3, 2023

OK, it really returns the ID - sorry I thought BsonValue holds the complete document, but it is only the ID...

@mbdavid mbdavid merged commit b1e8260 into mbdavid:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants