-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LiteFileStream.SetReadStreamPosition #2459
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
95e629b
Fix LiteFileStream.SetReadStreamPosition
SpaceCheetah 8827c39
Merge remote-tracking branch 'upstream/master' into FixSeek
20a88f3
Use TryGetValue
0ded5de
Add tests
d87ca9c
Merge branch 'FailingTests' into FixSeek
0b3a76a
rename to match convention
d2b3788
Merge branch 'FailingTests' into FixSeek
9473c1a
Support seeking past the end of a file
e1d2bce
Correct brace format
SpaceCheetah 4d58c69
More style changes
SpaceCheetah File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
using System; | ||
using System.IO; | ||
using Xunit; | ||
|
||
namespace LiteDB.Tests.Issues; | ||
|
||
public class Issue2458_Tests | ||
{ | ||
[Fact] | ||
public void NegativeSeekFails() | ||
{ | ||
using var db = new LiteDatabase(":memory:"); | ||
var fs = db.FileStorage; | ||
AddTestFile("test", 1, fs); | ||
using Stream stream = fs.OpenRead("test"); | ||
Assert.Throws<ArgumentOutOfRangeException>(() => stream.Position = -1); | ||
} | ||
|
||
//https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.position?view=net-8.0 says seeking to a position | ||
//beyond the end of a stream is supported, so implementations should support it (error on read). | ||
[Fact] | ||
public void SeekPastFileSucceds() | ||
{ | ||
using var db = new LiteDatabase(":memory:"); | ||
var fs = db.FileStorage; | ||
AddTestFile("test", 1, fs); | ||
using Stream stream = fs.OpenRead("test"); | ||
stream.Position = Int32.MaxValue; | ||
} | ||
|
||
[Fact] | ||
public void SeekShortChunks() | ||
{ | ||
using var db = new LiteDatabase(":memory:"); | ||
var fs = db.FileStorage; | ||
using(Stream writeStream = fs.OpenWrite("test", "test")) | ||
{ | ||
writeStream.WriteByte(0); | ||
writeStream.Flush(); //Create single-byte chunk just containing a 0 | ||
writeStream.WriteByte(1); | ||
writeStream.Flush(); | ||
writeStream.WriteByte(2); | ||
} | ||
using Stream readStream = fs.OpenRead("test"); | ||
readStream.Position = 2; | ||
Assert.Equal(2, readStream.ReadByte()); | ||
} | ||
|
||
private void AddTestFile(string id, long length, ILiteStorage<string> fs) | ||
{ | ||
using Stream writeStream = fs.OpenWrite(id, id); | ||
writeStream.Write(new byte[length]); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are at it, add a new line here