Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify with options #20

Merged
merged 5 commits into from Mar 18, 2021
Merged

Verify with options #20

merged 5 commits into from Mar 18, 2021

Conversation

MRoc
Copy link
Contributor

@MRoc MRoc commented Mar 3, 2021

Pass the options of authentication method to the verify callback. This allows the custom strategy to access those.

Done by checking the number of arguments of the callback for backward compatibility.

MRoc added 2 commits March 3, 2021 12:30
@MRoc
Pass options to verify callback
da87f4c 
This allows a custom strategy to access the options that
are originally passed to the authentication method.
@MRoc
Use strict equal
cee3d4b
@MRoc MRoc marked this pull request as ready for review March 3, 2021 11:35
@coveralls
Copy link

coveralls commented Mar 3, 2021 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 77209a5 on MRoc:verify_with_options into 8deb616 on mbell8903:master.

@mbell8903 mbell8903 merged commit 8a98d64 into mbell8903:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MRoc @coveralls @mbell8903