This repository has been archived by the owner on Nov 22, 2021. It is now read-only.
Use $q.when instead of .then to simplify auto-complete API #237
Milestone
Comments
|
Sounds like a great idea. I appreciate if you could send a PR with this improvement. :) |
mpolichette
pushed a commit
to SpinGo/ngTagsInput
that referenced
this issue
Sep 9, 2014
…to be a promise Use $q.when to remove api restriction that the result of loadFn must be a promise. This is a simple non-breaking addition which makes the API more simple to use. Closes mbenford#237
|
Done! With a passing test. I tried to match style, but I only dove in enough for this issue. :) |
|
Pulling this one in would be nice. So far I needed to include a promise polyfill into my web app just for this part of ngTagsInput. |
|
+1 for merge |
Bessonov
pushed a commit
to Bessonov/ngTagsInput.ie8
that referenced
this issue
May 3, 2015
…n a promise Use $q.when to remove api restriction that the result of the source option must be a promise. This is a simple non-breaking addition which makes the API more simple to use. Closes mbenford#237
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hey, small suggestion. If you would use $q.when on the result of the loadFN instead of calling .then on it, you could simplify the API without breaking backwards compatibility. Then the return from the loadFN could still be a promise, but would not HAVE TO be.
I could put this in a pull request if you would like!
Thanks for the awesome code!
The text was updated successfully, but these errors were encountered: