Calculate available volume using book percentage #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgegarcia7
commented
Feb 27, 2023
jorgegarcia7
commented
- calculate_available_volume() returns the available volume up to a certain max. book percentage.
…ertain max. level of overround.
mberk
requested changes
Feb 27, 2023
There was a problem hiding this comment.
- Can you lint with black (https://github.com/psf/black)?
- Can you add a docstring?
mberk
approved these changes
Feb 27, 2023
mberk
requested changes
Feb 27, 2023
betfairutil/__init__.py
Outdated
| """ | ||
| available_volume = 0 | ||
| for depth in range(10): | ||
| book_percentage, size = 0, 0 |
There was a problem hiding this comment.
Can you split this onto two separate lines?
betfairutil/__init__.py
Outdated
| :return: Available total volume. | ||
| """ | ||
| available_volume = 0 | ||
| for depth in range(10): |
There was a problem hiding this comment.
Can you replace with
for depth in itertools.count():
betfairutil/__init__.py
Outdated
| if book_percentage < max_book_percentage: | ||
| available_volume += size | ||
|
|
||
| return available_volume |
There was a problem hiding this comment.
Can you remove this line? Coverage has dropped because it never gets hit. But if we switch to itertools.count() above then this line is no longer needed
tests/test_non_prices.py
Outdated
| @@ -13,7 +13,7 @@ | |||
| from betfairlightweight.resources import RunnerBook | |||
| from pyrsistent import pmap | |||
|
|
|||
| from betfairutil import calculate_book_percentage | |||
| from betfairutil import calculate_book_percentage, calculate_available_volume | |||
There was a problem hiding this comment.
Can you put these on two separate lines?
mberk
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.