ci: update build #11
Open
ci: update build #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterschutt
commented
May 26, 2024
•
peterschutt
commented
- Updates GH Actions versions
- Updates maturin version
- Adds musl linux wheels
- Updates pyproject.toml where it diverged from spec (https://packaging.python.org/en/latest/guides/writing-pyproject-toml/)
peterschutt
commented
May 26, 2024
Comment on lines
+63
to
+76
| test-release: | ||
| name: Test Release | ||
| runs-on: ubuntu-latest | ||
| needs: [ macos, windows, linux ] | ||
| steps: | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| pattern: wheels_* | ||
| merge-multiple: true | ||
| path: dist | ||
| - name: Test Archive Download | ||
| run: | | ||
| echo "Testing archive download" | ||
| ls -la dist # List the contents to confirm download |
There was a problem hiding this comment.
I added this job as a sanity test for using the latest version of GH's upload/download artifact actions, as they no longer allow writing to the same archive across multiple jobs. The output of this basically shows us what would be in the dist/ directory in the publish job.
It also lets you easily see the wheels that are generated with this new config, e.g. here
There was a problem hiding this comment.
We can remove it once you've had a chance to take a look.
|
All looks good to me. I have created a minor release branch to merge this into. Do you want to remove the section referred to above and then I will merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.