Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve input validation #10

Merged
merged 9 commits into from
May 12, 2022
Merged

Improve input validation #10

merged 9 commits into from
May 12, 2022

Conversation

mberr
Copy link
Owner

@mberr mberr commented May 12, 2022

This PR deprecates positional arguments to public functions, and adds input validation to passed adjacency matrices.

fixes #9

mberr added 2 commits May 12, 2022 09:46
also emit warning if the adjacency looks like an edge index
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022

Codecov Report

Merging #10 (3d62bc5) into main (3daee4c) will decrease coverage by 0.54%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   79.85%   79.31%   -0.55%     
==========================================
  Files           4        4              
  Lines         139      145       +6     
  Branches       25       27       +2     
==========================================
+ Hits          111      115       +4     
- Misses         17       19       +2     
  Partials       11       11              
Impacted Files Coverage Δ
src/torch_ppr/utils.py 82.17% <0.00%> (-1.33%) ⬇️
src/torch_ppr/api.py 84.00% <100.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3daee4c...3d62bc5. Read the comment docs.

@mberr mberr merged commit d4a7498 into main May 12, 2022
@mberr mberr deleted the improve-input-validation branch May 12, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError torch.sparse.addmm different torch tensor shape
2 participants