Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sparse CSR support #15

Merged
merged 7 commits into from
Jun 21, 2022
Merged

Improve sparse CSR support #15

merged 7 commits into from
Jun 21, 2022

Conversation

mberr
Copy link
Owner

@mberr mberr commented Jun 21, 2022

At least on CPU, CSR matrices tend to be faster to multiply with a dense matrix.

Also sets the torch minimum version to 1.11

@codecov-commenter
Copy link

Codecov Report

Merging #15 (4b515fb) into main (91b7b36) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   85.90%   86.18%   +0.27%     
==========================================
  Files           4        4              
  Lines         149      152       +3     
  Branches       28       30       +2     
==========================================
+ Hits          128      131       +3     
  Misses         11       11              
  Partials       10       10              
Impacted Files Coverage Δ
src/torch_ppr/utils.py 87.96% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b7b36...4b515fb. Read the comment docs.

@mberr mberr merged commit 28a33ed into main Jun 21, 2022
@mberr mberr deleted the csr-support branch June 21, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants