Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm tyring to use your library with keycloak, and made a few changes to accommodate that use case:
encryptedKeyData
from EncryptedKey. It's not used anywhere and prevented the assertion from being parsed.Take for example (from here):
This parses as
Note how the
oneOrFail
applies the whole expression including the>=> parseXML
.The problem arises when
parseXML
throws an error. The correct behaviour is that the error gets thrown according to the MonadFail instance of the outer expression. However, becauseoneOrFail
expects a list, parseXML uses theMonadFail
instance of list, which just discards the error and returns an empty list.oneOrFail
then throws its own error.The result is that the error that
parseXML
threw is replaced, making debugging a lot harder.I replaced it with the following code, which propagates errors correctly: