Add subjectNameId to Subject #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fumieval
reviewed
Aug 8, 2022
mbg
reviewed
Aug 18, 2022
There was a problem hiding this comment.
Hi @kdxu, thank you for this contribution!
I am happy to accept this, although looking at the specification, the NameID element has some attributes that we might want to parse as well, such as Format. In which case, it might be good to introduce a new type here for NameID instead of just using Text. Even if you don't want to deal with parsing any attributes right now, it might be good to introduce that type in order to limit breaking changes in the future.
|
Thanks for making the change @kdxu! |
|
This is now released as https://hackage.haskell.org/package/wai-saml2-0.3.0.0, thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
subjectNameId, so that SP can identify users by identifier.