Add a function that generates an SP initiated SSO request #19
Conversation
fumieval
force-pushed
the
sp-initiated
branch
from
56057c9
to
db6fe67
Compare
There was a problem hiding this comment.
It looks like most of new the Haskell file is formatted using Ormolu (or similar), although there is some inconsistent indentation. It would be good if the formatting could be more in line with the other files, as per the contribution guidelines for style.
fumieval
force-pushed
the
sp-initiated
branch
2 times, most recently
from
b07ddac
to
c09c639
Compare
|
@fumieval Thanks for your work on this and the changes you have made in response to the review. It seems that the formatting and documentation are still outstanding. Is that something you are still planning to do? If not, I can deal with the documentation and re-format the code. |
fumieval
force-pushed
the
sp-initiated
branch
2 times, most recently
from
2fcfc64
to
6379cb9
Compare
|
I'm afraid I'm not really sure what the issues with documentation and formatting are. Could you reformat the code? |
fumieval
force-pushed
the
sp-initiated
branch
from
6379cb9
to
208eba3
Compare
|
No problem and thanks for this contribution! :) I have merged it and pushed my changes on top. You may wish to have a look over those to make sure all is good with you as well. |
|
Thank you for making up the documentation! |
This PR adds a basic support for SP-initiated flow. I confirmed that it works with Google Workspace