Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make SP private key optional #37

Merged
merged 2 commits into from Dec 23, 2022
Merged

make SP private key optional #37

merged 2 commits into from Dec 23, 2022

Conversation

fumieval
Copy link
Contributor

@fumieval fumieval commented Dec 19, 2022 •
edited

Checklist

  • All definitions are documented with Haddock-style comments.
  • All exported definitions have @since annotations.
  • Code is formatted in line with the existing code.
  • The changelog has been updated.

This change changes the type of saml2PrivateKey field to Maybe PrivateKey. It rejects encrypted assertions when this is set to Nothing.

Hopefully this change breaks little code, assuming that SAML2Config is constructed via the saml2Config function.

@github-actions github-actions bot requested a review from mbg December 19, 2022 06:12
mbg
mbg requested changes Dec 19, 2022
View reviewed changes
Copy link
Owner

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always for the contribution @fumieval! I have commented with a few thoughts on the design decisions in this change - let me know what you think!

CHANGELOG.md Outdated Show resolved Hide resolved
src/Network/Wai/SAML2/Config.hs Outdated Show resolved Hide resolved
src/Network/Wai/SAML2/Config.hs Outdated Show resolved Hide resolved
src/Network/Wai/SAML2/Validation.hs Outdated Show resolved Hide resolved
@mbg mbg mentioned this pull request Dec 19, 2022
Closed
4 tasks
@fumieval fumieval force-pushed the optional-private-key branch 4 times, most recently from 100eea1 to 4501ce1 Compare December 19, 2022 16:01
mbg
mbg approved these changes Dec 23, 2022
View reviewed changes
Copy link
Owner

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much! 😄

CHANGELOG.md Outdated Show resolved Hide resolved
@fumieval @mbg
Update CHANGELOG.md
ccf8145 
Co-authored-by: Michael B. Gale <mbg@github.com>
@fumieval
Copy link
Contributor Author

Thank you too for reviewing!

@mbg mbg merged commit 3c933d7 into mbg:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbg mbg mbg approved these changes

Assignees

@fumieval fumieval

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fumieval @mbg