Fixed a bug in XML canonicalisation causing a digest mismatch on Okta… #51
+36
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbg
reviewed
Jun 24, 2023
… when attributes are present When parsing a SAML response, it has been inappropriately stripping `xmlns:xs="http://www.w3.org/2001/XMLSchema"` attribute in saml2:Assertion. This was causing a discrepancy between Okta's digest and our digest (but only when AttributeStatement is present). This change fixes the problem by setting `psRetainNamespaces = True` and adding "xs" to the list of allowed prefixes for c14n. Special thanks to @hiroqn for figuring this out
|
Thank you for reviewing. I updated documentation of those functions (also rebased the branch in order to fix a conflict). |
mbg
approved these changes
Jun 25, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when attributes are present
When parsing a SAML response, it has been inappropriately stripping
xmlns:xs="http://www.w3.org/2001/XMLSchema"attribute in saml2:Assertion. This was causing a discrepancy between Okta's digest and our digest (but only when AttributeStatement is present).This change fixes the problem by setting
psRetainNamespaces = Trueand adding "xs" to the list of allowed prefixes for c14n.Special thanks to @hiroqn for figuring this out
Summary
Checklist
@sinceannotations.