Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

request: mute currently playing sound when switching channels, instead of continuing playback with destination-channel's preset #52

Closed
esaruoho opened this issue Oct 8, 2017 · 0 comments

Comments

@esaruoho
Copy link
Contributor

esaruoho commented Oct 8, 2017

please protect user from accidental deafness:
steps to replicate.

  1. Create a sound that has full clip and full distortion to channel1
  2. Create a sound that has a long long long release to channel2
  3. Play notes in channel2
  4. Switch to channel1

Expected result:
All playing sound in channel2 either continues playing, or is muted

Current result:
Channel2 playing sound "preset" is switched to channel1 "preset", causing at best annoying spikes in audio, at worst, tinnitus/deafness, depending on what you do with the settings.

please protect user from these

vsariola pushed a commit to vsariola/soundbox that referenced this issue Oct 13, 2017
…hen changing instruments.

In jammer, if old notes were playing when changing to a new instrument, the old notes continued to play with the new instrument. If the new instrument was much louder than the old, the user might damage her ears. Prevent deafness by muting the sound if more than one setting was changed simultaneously (e.g. loading a new preset or changing from one channel to another).

Fixes mbitsnbites#52
vsariola pushed a commit to vsariola/soundbox that referenced this issue Oct 13, 2017
…hen changing instruments.

In jammer, if old notes were playing when changing to a new instrument, the old notes continued to play with the new instrument. If the new instrument was much louder than the old, the user might damage her ears. Prevent deafness by muting the sound if more than one setting was changed simultaneously (e.g. loading a new preset or changing from one channel to another).

Fixes mbitsnbites#52
mbitsnbites pushed a commit that referenced this issue Oct 22, 2017
…hen changing instruments.

In jammer, if old notes were playing when changing to a new instrument, the old notes continued to play with the new instrument. If the new instrument was much louder than the old, the user might damage her ears. Prevent deafness by muting the sound if more than one setting was changed simultaneously (e.g. loading a new preset or changing from one channel to another).

Fixes #52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant