Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out of bound exception #104

Closed
danielvladco opened this issue Dec 24, 2018 · 1 comment
Closed

out of bound exception #104

danielvladco opened this issue Dec 24, 2018 · 1 comment

Comments

@danielvladco
Copy link

getColorObject(tinycolor.mix(baseDark, baseTriad[4], 15).saturate(80).lighten(65), 'A100'),

In this line as well as in the next three you try to get element with index 4 of the array but according to the tinycolor api there are 4 elements in this array which means that the last element in array will be with index 3. baseTriad[4] is undefined and tinycolor sets it to default.

@mbitson
Copy link
Owner

mbitson commented Apr 29, 2020

Hey there @danielvladco !

Thank you for your report! This has recently been fixed in this PR: #105

I've got this deployed now to the tool, here: http://mcg.mbitson.com/

Please let me know if you notice anything else! Thanks again!

@mbitson mbitson closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants