-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a quick fix for tetrad array element selection bug. #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tabuckner !
Thank you so much for your interest in the project and your commit here! You're adjusting one of the particular color algorithms, where instead you should be making a third algorithm option for the settings. At that point we'd need to adjust the if{}else{} statement to be more robust and call any one of the three possible algorithms for color generation.
If we did that I'd go ahead and merge this in. I don't have a lot of time lately, but I may come back and help adjust.
Thanks!
@mbitson sure, i can do that! One sec |
@mbitson made a few changes, and I think this oughta do the trick: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tabuckner !
Impressive work, thank you sir!
I'll get this deployed to my copy of the tool soon.
@mbitson No worries :], I'm glad I was able to contribute! You helped me out of a bind by making this OS! |
Thank you again for this fix, @tabuckner ! Getting this repo cleaned up and this is helpful! |
Of course!! Thank you for what you've done! Let me know if you want any help I'd love to give back 😄 |
@mbitson @fireflight1 @simon04 Discovered this while making a SASS adaptation of your approach. Thank you so much for making this open source! It's still not perfect, and might not look good for all colors, but I feel it's a closer approximation.
tinycolor.tetrad()
returns an array with a length of 4. Targeting index[4]
returnsundefined
.tinycolor.mix()
does not complain about an undefined value for argument 2, but we're not correctly handling the mix approach.Using @angular/material as a baseline, I tweaked the values to somewhat more closely match the
mat-indigo
palette.Mat-Indigo
New values