This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
Fix package dependencies to be fully specified #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicallan
reviewed
Aug 31, 2020
package.yaml
Outdated
| - source-constraints | ||
| - template-haskell | ||
| - text | ||
| - base > 4.12 && < 14.15 |
There was a problem hiding this comment.
The 14.15 on this line should probably be 4.15.
Can we also do greater or equal to >= 4.12 as a lower bound so that we can support 8.6 and above? Not a blocker, could make changes in another iteration.
There was a problem hiding this comment.
Unless we had a build on 8.6 that works I'd not want to declare 8.6 support. source-constraints etc do not support 8.6 at this point.
I'd rather spend my energy forwards than backwards.
There was a problem hiding this comment.
Unless we had a build on 8.6 that works I'd not want to declare 8.6 support. source-constraints etc do not support 8.6 at this point.
I'd rather spend my energy forwards than backwards.
Makes sense.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance