Update reek, rubocop, mutant, and mutant-rspec #79
Conversation
backus
force-pushed
the
feature/update-gems
branch
from
fc5f0d4
to
a7d6ab0
Compare
|
Looks like something broke with reek's rake task between 3.2.1 and 3.3.0. |
| @@ -150,7 +150,7 @@ class Mutant < self | |||
| # Devtools configuration | |||
| class Devtools < self | |||
| FILE = 'devtools.yml'.freeze | |||
| DEFAULT_UNIT_TEST_TIMEOUT = 0.1 # 100ms | |||
| DEFAULT_UNIT_TEST_TIMEOUT = 0.1 # 100ms | |||
There was a problem hiding this comment.
I generally leave two spaces before trailing comments only to make it more obvious that the comment is not part of the code.
Is there a rubocop setting that might allow 2 spaces for trailing comments?
There was a problem hiding this comment.
Is there a rubocop setting that might allow 2 spaces for trailing comments?
@backus do you mind to look that up? and adjust the setting if available, or deactivating the cop otherwise?
There was a problem hiding this comment.
Yeah sure I'll take a look. It is from Style/ExtraSpacing and the discussion around what was added is here rubocop/rubocop#2035. Not sure yet about config
There was a problem hiding this comment.
Seems like the only option is AllowForAlignment so I'll remove
|
I'm just going to drop the reek dependency down to 3.2.1 since I don't want to dive any deeper into reek right now to figure out the issue |
I'm fine to merge any improvement. |
ExtraSpacing is enabled by default in rubocop 0.33 and it does not align with the conventions used in devtools so we disable it.
- reek updated to 3.2.1 - rubocop updated to 0.33 - mutant updated to 0.8.3 - mutant-rspec updated to 0.8.2
backus
force-pushed
the
feature/update-gems
branch
from
a7d6ab0
to
ce09dce
Compare
|
Updated |
Update reek, rubocop, mutant, and mutant-rspec
|
@backus thx again! |
|
@backus awesome, thanks! |
|
Reek issue previously mentioned: troessner/reek#642. I guess we should expect a fix to be released soon? troessner/reek#644 |
|
Looks like that fix addressed some use cases but not the syntax that devtools uses. See my comment here: troessner/reek#642 (comment) |
|
Cool they fixed it already troessner/reek#683 |
|
Released! troessner/reek#684 I'll open a new PR |
3.3.03.2.1