[work-pool] Add work-pool subproject #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mbj
commented
Jun 3, 2024
mbj
commented
- This is an extraction from my mutant-manager project.
mbj
force-pushed
the
add/work-pool
branch
3 times, most recently
from
f9d7f2d
to
9aa4436
Compare
mbj
force-pushed
the
add/work-pool
branch
2 times, most recently
from
31482d5
to
edf2e0e
Compare
epicallan
reviewed
Jun 3, 2024
mbj
force-pushed
the
add/work-pool
branch
5 times, most recently
from
8f21ea2
to
c3bbefb
Compare
* This is an extraction from my mutant-manager project.
dkubb
reviewed
Jun 7, 2024
Comment on lines
+30
to
+32
| , workerRun :: Natural -> Source a -> m Done | ||
| -- ^ function called when a worker is booted, argument is the worker index, | ||
| -- and a source to be drained with `runSource` |
There was a problem hiding this comment.
suggestion: If nothing yet uses the index, I would probably remove it from the interface and add it when it is needed.
EDIT: It's possible the tests don't use it, but other code does. If so, then I'd suggest adding a test to exercise it.
dkubb
reviewed
Jun 7, 2024
dkubb
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.