Add unused group name mutation #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgollahon
changed the title
dgollahon
changed the title
dgollahon
force-pushed
the
add-named_group-name-mutation
branch
2 times, most recently
from
875b1bb
to
16e5211
Compare
dgollahon
commented
Jan 3, 2021
Comment on lines
22
to
23
| unless name_underscored? | ||
| emit(s(:regexp_passive_group, group)) |
There was a problem hiding this comment.
@mbj What do you think of this behavior? I added the passive group mutation to the guard so that if you deliberately underscore a named group (sort of like a comment) you are able to keep it and not be forced to the non-capturing passive group. I could also move it outside of the guard but this was my intuition for what I would likely prefer if I were a user.
dgollahon
force-pushed
the
add-named_group-name-mutation
branch
from
16e5211
to
d646dfe
Compare
dgollahon
force-pushed
the
add-named_group-name-mutation
branch
2 times, most recently
from
2e09662
to
3887b37
Compare
mbj
approved these changes
Jan 4, 2021
- Mutates capture group names: `/(?<foo>bar)/` -> `/(?<_foo>bar)/`. - Closes #573. NOTE: I have deviated from the issue slightly and chosen a `_` prefix so that, like with local variables, names can be left in unused if they are explicitly marked as such. I have decided to extend the behavior to not mutating to a non-capture group as well in this case because the `_` prefix seems like a clear choice that the user would rather keep the label even if the capturing functionality is unused.
dgollahon
force-pushed
the
add-named_group-name-mutation
branch
from
3887b37
to
1c4f875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/(?<foo>bar)/->/(?<_foo>)/./(?<foo>)/→/(?<foo__mutant__>)/#573. NOTE: I have deviated from the issue slightly and chosen a_prefix so that, like with local variables, names can be left in unused if they are explicitly marked as such. I have decided to extend the behavior to not mutating to a non-capture group as well in this case because the_prefix seems like a clear choice that the user would rather keep the label even if the capturing functionality is unused.