Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs on ruby 3.1.3 #1362

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Fix specs on ruby 3.1.3 #1362

merged 1 commit into from
Jan 6, 2023

Conversation

mbj
Copy link
Owner

@mbj mbj commented Jan 6, 2023

No description provided.

* Ruby 3.1.3 changed that module inherited methods that underwent
  visibiltiy changes are now owned by the class.
* This makes it impossible for mutant to exclude these methods anymore
  from the class coverage subjects.
* This may actually be preferable for public methods as they form part
  of the public interface.
* Mutant now emits more subjects, eventually users will have to use
  explicit targeting to cover that "re-appearing" subjects.
* As the case to "just" change visibiltiy in module inherited methods is
  quite rare I expect no significant user experience changes.
@mbj mbj self-assigned this Jan 6, 2023
@mbj mbj added the maintenance label Jan 6, 2023
@mbj mbj merged commit 4ff4a00 into main Jan 6, 2023
@mbj mbj deleted the fix/3.1.3 branch January 6, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant