Change to improved rspec example selection #1373

mbj · 2023-04-30T01:14:12Z

Before we'd traverse the entire filtered examples explicitly removing the selection where required.
This is inefficient especially on larger example numbers.
The new strategy wipes all examples during setup once, and only re-enables selected examples efficiently and targeted.

* Before we'd traverse the entire filtered examples explicitly removing the selection where required. * This is inefficient especially on larger example numbers. * The new strategy wipes all examples during setup once, and only re-enables selected examples efficiently and targeted.

mbj · 2023-04-30T01:22:11Z

lib/mutant/integration/rspec.rb

@@ -119,12 +139,6 @@ def all_examples
        end
      end

-      def filter_examples(&predicate)
-        @rspec_world.filtered_examples.each_value do |examples|


Per mutation this was for 99% of the examples resulting in the same result: Clearing the array entirely.

mbj commented Apr 30, 2023

View reviewed changes

mbj merged commit eda5ef8 into main Apr 30, 2023
71 checks passed

mbj deleted the change/to-improved-rspec-test-setup branch April 30, 2023 01:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change to improved rspec example selection #1373

Change to improved rspec example selection #1373

mbj commented Apr 30, 2023

mbj Apr 30, 2023

Change to improved rspec example selection #1373

Change to improved rspec example selection #1373

Conversation

mbj commented Apr 30, 2023

mbj Apr 30, 2023

Choose a reason for hiding this comment