Significantly optimize parsing overhead when --since is specified
#1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgollahon
changed the title
--since is specified
dgollahon
force-pushed
the
optimize-parsing
branch
from
5fab944
to
eb7a079
Compare
dgollahon
commented
May 14, 2023
| @@ -120,6 +120,11 @@ def subject_config(node) | |||
| def matched_view | |||
There was a problem hiding this comment.
@mbj there is something wrong or incomplete with mutant or the zombification process. When I tried to mutate Mutant::Matcher::Method it found zero subjects. I had the same behavior on master as well so it was not introduced by this change.
There was a problem hiding this comment.
Works perfectly for me on main. Can you share a reproducing CLI?
dgollahon
force-pushed
the
optimize-parsing
branch
4 times, most recently
from
bc2dc3f
to
b25306a
Compare
mbj
reviewed
May 21, 2023
mbj
reviewed
May 21, 2023
- An identical expectation is included via the `skipped candidate` shared example in `spec/shared/method_matcher_behavior.rb`.
dgollahon
force-pushed
the
optimize-parsing
branch
3 times, most recently
from
3672729
to
ad93a3f
Compare
dgollahon
commented
May 21, 2023
dgollahon
commented
May 21, 2023
…iffs
* Avoids parsing source files that live outside the specified diff.
* Massively speeds up boot time on larger codebases and should be noticeable on all sizes.
On `mutant` itself, when making a relatively targeted change (such as this one),
boot time is reduced by about 0.7 seconds (~20% faster).
On a larger project I work on, the speed up was 24 seconds or 2.5x faster overall!
I left the original, full, subject filtering in place to simplify this change.
This just short-circuits when the files we are interested in are not modified
and `--since` is specified.
* `mutant` run before on this change:
```
Benchmark 1: bundle exec mutant run --zombie --since HEAD~1 --profile
Time (mean ± σ): 4.192 s ± 0.350 s [User: 8.567 s, System: 6.081 s]
Range (min … max): 3.850 s … 4.960 s 10 runs
```
* `mutant` run after on this change:
```
Benchmark 1: bundle exec mutant run --zombie --since HEAD~1 --profile
Time (mean ± σ): 3.535 s ± 0.213 s [User: 6.890 s, System: 5.784 s]
Range (min … max): 3.188 s … 3.784 s 10 runs
```
* Also reduces memory consumption significantly since the ASTs for all source files
are never constructed.
In my larger project on very small single subject change it reduced memory
allocations by 69MB (80% reduction) and reduced "retained" memory by 25MB
(99.4% reduction).
mbj
reviewed
May 22, 2023
| @@ -103,10 +102,7 @@ def add_matcher_options(parser) | |||
| add_matcher(:start_expressions, @config.expression_parser.call(pattern).from_right) | |||
| end | |||
| parser.on('--since REVISION', 'Only select subjects touched since REVISION') do |revision| | |||
| add_matcher( | |||
| :subject_filters, | |||
There was a problem hiding this comment.
@dgollahon I could get a rid of the entire subject_filters after checking private integrations, they where ported to the hooks subsystem so no need to maintain this API. this overall makes this commit much nicer than previous versions.
There was a problem hiding this comment.
Awesome! Thank you for validating and simplifying that. I think it's much nicer code-wise, just didn't realize it was an option.
mbj
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mutantitself, when making a relatively targeted change (such as this one), boot time is reduced by about 0.7 seconds (~20% faster). On a larger project I work on, the speed up was 24 seconds or 2.5x faster overall! I left the original, full, subject filtering in place to simplify this change. This just short-circuits when the files we are interested in are not modified and--sinceis specified.mutantrun before on this change:mutantrun after on this change: