Fix rspec is quitting signal #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
force-pushed
the
add/rspec-is-quitting-signal
branch
from
ecbc6d2
to
d248c43
Compare
mbj
commented
Mar 20, 2024
| @@ -102,6 +102,14 @@ def available_tests | |||
|
|
|||
| private | |||
|
|
|||
| def rspec_setup_failure? | |||
| @rspec_world.wants_to_quit || rspec_is_quitting? | |||
There was a problem hiding this comment.
RSpec (3.9 and above) have "more than one signal" that setup failed. Mutant needs to respect both. One would assume that rspec_is_quitting would imply wants_to_quit but this is not the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.