Checkin Gemfile.lock for deterministic builds #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
force-pushed
the
fix/add-gemfile-lock
branch
from
55cf71c
to
984bdc8
Compare
|
@mbj what about just adding harder constraints in the Gemfile? |
less easy to maintain. |
* Bump `regexp_parser` dependency * Simplify `regexp_parser` call side * Fix corpus checkout indeterminism * Checkin Gemfile.lock for deterministic builds * Set circle ruby to 2.3.3
mbj
force-pushed
the
fix/add-gemfile-lock
branch
5 times, most recently
from
57d1236
to
33a105a
Compare
mbj
force-pushed
the
fix/add-gemfile-lock
branch
6 times, most recently
from
c56619b
to
3c7434a
Compare
mbj
force-pushed
the
fix/add-gemfile-lock
branch
8 times, most recently
from
1702ee4
to
d20d997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The referenced gems (especially rubocop) innovate on point releases. Deterministic builds are important, nothing that is green on a PR that is merged later to master should be red on merged to master.