Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutator for self nodes #72

Merged
merged 1 commit into from
Jul 23, 2013
Merged

Add mutator for self nodes #72

merged 1 commit into from
Jul 23, 2013

Conversation

dkubb
Copy link
Collaborator

@dkubb dkubb commented Jul 23, 2013

This branch adds a mutator for self nodes.

@mbj
Copy link
Owner

mbj commented Jul 23, 2013

@dkubb I'm not really convinced these are valid mutations. self is never ever nil. A mutation IMHO should force to test for a state that is "reachable". That nil for self is not.

@dkubb
Copy link
Collaborator Author

dkubb commented Jul 23, 2013

@mbj what about a bare self? If it were mutated to nil and did not cause a spec failure, then that would probably be dead code.

mbj added a commit that referenced this pull request Jul 23, 2013
Add mutator for self nodes
@mbj mbj merged commit 29f31b6 into master Jul 23, 2013
@mbj
Copy link
Owner

mbj commented Jul 23, 2013

@dkubb Okay. But dead code should normally be "spotted" by statement deletion. But I realized I'm inconsistent with myself. We also mutate literals to nil. So we can do the same to with self.

@dkubb dkubb deleted the self-mutator branch July 23, 2013 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants