Change to use base-compat prelude #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicallan
commented
May 17, 2020
| @@ -4,13 +4,16 @@ github: mbj/tasty-mgolden | |||
| description: Golden testing provider for tasty with muti-line diff output | |||
| license: BSD3 | |||
| author: Markus Schirp <mbj@schirp-dso.com> | |||
| tested-with: GHC == 8.6.5 | |||
There was a problem hiding this comment.
I tested this locally but adding CI for this version would be good to.
mbj
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base-compat's Prelude makes it easier to take advantage of the latest Prelude that's also compatible with earlier GHC releases.
So instead of having multiple explicit imports and elimination of the default prelude so as to ensure backward compatibility; we can make use of base-compat's prelude for a compatible prelude.
This PR also doesn't add much in terms of features so feel free to ignore it if you prefer to maintain the explicit imports.
P.S
base-compathas zero dependencies