Sidebar closing when clicking inside it

[RomkaLTU]

It's happening when you click something inside the sidebar, for example trying to clikc on text input ant type something. Text input is inside slot.

<Slide right>
  <div><input type="text"></div>
</Slide>

[jesperholstjh]

Have a look at #30. The issue is fixed but @mbj36 hasn't merged it to master. We are also waiting for this.

[mbj36]

It's merged @jesperholstjh

[toyoshima-c-fixer]

@mbj36
Has it been modified? Looks like it still closes when clicking inside.

[Brice187]

Found the issue in vue-burger-menu.common.js:

if (element && element !== target && !element.contains(target) && e.target.className !== 'bm-menu' && this.isSideBarOpen && !this.disableOutsideClick) {
    this.closeMenu();
}

The condition e.target.className !== 'bm-menu' only checks the class of the top level elements. if these have child elements that do not have "bm-menu", the click is considered "outside"

[gavinhewitt]

Having the same issue

[Brice187]

i fixed it in my PR, have a look or wait for the maintainer to merge the PR ;)