Skip to content

Commit

Permalink
Fix parameter-overrides by fixing EMAIL_SITE_TITLE
Browse files Browse the repository at this point in the history
I noticed that the EMAIL_SITE_TITLE and SENDER_NAME values passed
through to the dev and prod pipeline deployments were both only "Mike".
Properly escaping spaces in EMAIL_SITE_TITLE should fix this.
  • Loading branch information
mbland committed Apr 8, 2023
1 parent 01792f5 commit 0e44237
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion bin/sam-with-env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,15 @@ elif [[ "$#" -eq 0 ]]; then
fi
. "$ENV_FILE" || exit 1

# Check these parameters first, since we escape spaces in them later.
printf "${EMAIL_SITE_TITLE:?}" >/dev/null
printf "${SENDER_NAME:?}" >/dev/null

PARAMETER_OVERRIDES=(
"ApiDomainName=${API_DOMAIN_NAME:?}"
"ApiMappingKey=${API_MAPPING_KEY:?}"
"EmailDomainName=${EMAIL_DOMAIN_NAME:?}"
"EmailSiteTitle=${EMAIL_SITE_TITLE:?}"
"EmailSiteTitle=${EMAIL_SITE_TITLE// /\ }"
"SenderName=${SENDER_NAME// /\ }"
"SubscribersTableName=${SUBSCRIBERS_TABLE_NAME:?}"
"InvalidRequestPath=${INVALID_REQUEST_PATH:?}"
Expand Down

0 comments on commit 0e44237

Please sign in to comment.