Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace individual $'\n' instances with full $'...' strings #69

Closed
mbland opened this issue Dec 28, 2016 · 0 comments
Closed

Replace individual $'\n' instances with full $'...' strings #69

mbland opened this issue Dec 28, 2016 · 0 comments
Assignees
@mbland
Labels
maintenance

Comments

@mbland
Copy link
Owner

mbland commented Dec 28, 2016

Silly me, I just realized that you can include an entire string in $'...', not just the \n or other control characters.
@mbland mbland self-assigned this Dec 28, 2016
mbland added a commit that referenced this issue Jan 2, 2017
@mbland
Replace single $'\n' instances where possible
bf5dd98 
Closes #69. Note that in cases where the `\n` is concatenated with a
string that contains a variable expansion, the single `$'\n'` must
stand, because variable expansion does not take place within `$'...'`.
@mbland mbland mentioned this issue Jan 2, 2017
Merged
mbland added a commit that referenced this issue Jan 2, 2017
@mbland
validation: Use $' for __GO_VALIDATE_INPUT_PATTERN
c95d3bc 
Part of #69.
@mbland mbland closed this as completed in #81 Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbland mbland

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbland